Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cypress Failure in Facility and Resource Page #6293

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Sep 14, 2023

WHAT

🤖 Generated by Copilot at 32e0c38

The pull request refactors and improves the cypress tests for the facility and resource features. It removes unused and duplicated code, extracts common methods, uses page object classes and variables, and adds assertions for the API responses and the URL formats.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 32e0c38

  • Remove unused phone_number variable from facility.cy.ts (link)
  • Refactor code to verify new URL after saving and exiting doctor form into a separate method in FacilityPage class (link)
  • Add code to intercept and assert GET request for facility API in saveAndExitDoctorForm method to improve test reliability (link)
  • Add methods to verify new URL format for facility and resource in FacilityPage class using regular expressions (link)
  • Remove duplicate test case to create resource request from facility page from facility.cy.ts (link)
  • Import FacilityPage class and declare variables for facility page, phone number and created resource in resource.cy.ts (link)
  • Add test case to create resource request from facility page in resource.cy.ts using facilityPage methods and store new URL in createdResource variable (link)
  • Modify test case to open created resource in resource.cy.ts to use createdResource variable instead of resourcePage method (link)
  • Remove unused code to open created resource from ResourcePage class (link)

@nihal467 nihal467 requested a review from a team September 14, 2023 22:41
@nihal467 nihal467 requested a review from a team as a code owner September 14, 2023 22:41
@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 0:04am

@nihal467 nihal467 requested a review from bodhish September 14, 2023 22:41
@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cc89ceb
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6504480639477f00081c941e
😎 Deploy Preview https://deploy-preview-6293--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #1262 ↗︎

0 71 0 0 Flakiness 0

Details:

Fixed Cypress Failure in Facility and Resource Page
Project: CARE Commit: cc89ceb1f3
Status: Passed Duration: 02:46 💡
Started: Sep 15, 2023 12:07 PM Ended: Sep 15, 2023 12:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@khavinshankar khavinshankar merged commit 5ac9e15 into develop Sep 15, 2023
@khavinshankar khavinshankar deleted the Fix-Cypress-Failure branch September 15, 2023 12:14
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants